Horton

Re: [PATCH] Improve geometric types

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

View thread View on postgr.es
From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: emre@hasegeli.com
Cc: a.alekseev@postgrespro.ru, pgsql-hackers@postgresql.org
Date: 2017-09-15T08:43:39Z
Lists: pgsql-hackers 
Hello, just one point on 0001.

The patch replace pg_hypot with hypot in libc. The man page says
as follows.

man 3 hypot
>       If the result overflows, a range error occurs, and the functions return
>       HUGE_VAL, HUGE_VALF, or HUGE_VALL, respectively.
..
>ERRORS
>       See math_error(7) for information on how to determine whether an  error
>       has occurred when calling these functions.
>
>       The following errors can occur:
>
>       Range error: result overflow
>              errno  is  set  to ERANGE.  An overflow floating-point exception
>              (FE_OVERFLOW) is raised.
>
>       Range error: result underflow
>              An underflow floating-point exception (FE_UNDERFLOW) is raised.
>
>              These functions do not set errno for this case.

So, the code seems to need some amendments following to this
spec.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Improve test coverage of geometric types

  2. Fix problems in handling the line data type

  3. Use the built-in float datatypes to implement geometric types

  4. Remove remaining GEODEBUG references from geo_ops.c

  5. Provide separate header file for built-in float types

  6. Refactor geometric functions and operators

  7. Fix crash in close_ps() for NaN input coordinates.

  8. Fix GiST index build for NaN values in geometric types.

  9. Enable building with Visual Studion 2013.

  10. Suppress -0 in the C field of lines computed by line_construct_pts().