Horton

Re: Bug in ExecModifyTable function and trigger issues for foreign tables

Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>

View thread View on postgr.es
From: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Dilip Kumar <dilipbalaut@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2017-09-12T15:26:22Z
Lists: pgsql-hackers 
On Mon, 24 Jul 2017 11:59:13 +0900
Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote:

> On 2017/07/21 19:16, Etsuro Fujita wrote:
> > On 2017/07/20 11:21, Etsuro Fujita wrote:  
> >> On 2017/07/19 23:36, Tom Lane wrote:  
> >>> Please put the responsibility of doing const-expression
> >>> simplification in these cases somewhere closer to where the
> >>> problem is being created.  
> >>
> >> It would be reasonable that it's the FDW's responsibility to do
> >> that const-simplification if necessary?  
> > There seems to be no objections, so I removed the const-expression 
> > simplification from the patch and I added the note to the docs for 
> > AddForeignUpdateTargets.
> > 
> > Attached is an updated version of the patch.  
> 
> I cleaned up the patch a bit.  PFA a new version of the patch.
> 
> Best regards,
> Etsuro Fujita

Checked, looks good to me. Changed status to 'Ready for Commiter'.

-- 
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Commits

  1. Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE.