Re: Allow GiST opcalsses without compress\decompres functions
Dmitriy Sarafannikov <dsarafannikov@yandex.ru>
From: Dmitriy Sarafannikov <dsarafannikov@yandex.ru>
To: pgsql-hackers@postgresql.org
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Date: 2017-09-11T07:57:43Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation: not tested Hi Andrew! Thanks for the patch, but patch 0001-allow-uncompressed-Gist-2.patch no longer applies on current master branch. Please could you rebase it? Some info from git apply command: Checking patch doc/src/sgml/gist.sgml... Checking patch src/backend/access/gist/gist.c... Checking patch src/backend/access/gist/gistget.c... Checking patch src/backend/access/gist/gistutil.c... error: while searching for: GISTENTRY *dep; gistentryinit(*e, k, r, pg, o, l); dep = (GISTENTRY *) DatumGetPointer(FunctionCall1Coll(&giststate->decompressFn[nkey], giststate->supportCollation[nkey], error: patch failed: src/backend/access/gist/gistutil.c:550 error: while searching for: gistentryinit(centry, attdata[i], r, NULL, (OffsetNumber) 0, isleaf); cep = (GISTENTRY *) DatumGetPointer(FunctionCall1Coll(&giststate->compressFn[i], giststate->supportCollation[i], PointerGetDatum(¢ry))); compatt[i] = cep->key; } } error: patch failed: src/backend/access/gist/gistutil.c:585 Hunk #3 succeeded at 648 (offset -7 lines). Hunk #4 succeeded at 924 (offset -7 lines). Hunk #5 succeeded at 944 (offset -7 lines). Checking patch src/backend/access/gist/gistvalidate.c... Applied patch doc/src/sgml/gist.sgml cleanly. Applied patch src/backend/access/gist/gist.c cleanly. Applied patch src/backend/access/gist/gistget.c cleanly. Applying patch src/backend/access/gist/gistutil.c with 2 rejects... Rejected hunk #1. Rejected hunk #2. Hunk #3 applied cleanly. Hunk #4 applied cleanly. Hunk #5 applied cleanly. Applied patch src/backend/access/gist/gistvalidate.c cleanly. The new status of this patch is: Waiting on Author
Commits
-
Allow no-op GiST support functions to be omitted.
- d3a4f89d8a3e 11.0 landed
-
Remove no-op GiST support functions in the core GiST opclasses.
- 2d484f9b0580 11.0 landed