Re: pgbench tap tests & minor fixes.

Alvaro Herrera <alvherre@alvh.no-ip.org>

From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Fabien COELHO <coelho@cri.ensmp.fr>
Date: 2017-09-04T13:56:01Z
Lists: pgsql-hackers
Michael Paquier wrote:
> On Thu, Aug 31, 2017 at 9:29 PM, Nikolay Shaplov <dhyan@nataraj.su> wrote:
> > I am about to set "Ready for commit" status to this patch. So there is my
> > summary for commiter, so one does not need to carefully read all the thread.
> >
> > This patch is consists of three parts. May be they should be commited
> > separately, then Fabien will split them, I think.
> 
> I am not sure why, but this email has broken the whole thread on my
> gmail client... Did you change the subject name indirectly? The thread
> is shaped correctly in postgresql.org though.

Threading in postgresql.org uses the References and In-Reply-To headers
in order to build the threads, and ignores Subject, whereas Gmail breaks
threads as soon as the subject is changed.  The message by Nikolay has a
period at end of subject.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Add much-more-extensive TAP tests for pgbench.

  2. Be more careful about newline-chomping in pgbench.

  3. Fix some subtle problems in pgbench transaction stats counting.