Re: Re: [PATCH] Fix drop replication slot blocking instead of returning error
Noah Misch <noah@leadboat.com>
From: Noah Misch <noah@leadboat.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Simone Gotti <simone.gotti@gmail.com>, pgsql-hackers@postgresql.org
Date: 2017-09-01T02:14:03Z
Lists: pgsql-hackers
On Tue, Aug 29, 2017 at 12:04:33PM +0200, Alvaro Herrera wrote: > Noah Misch wrote: > > On Thu, Aug 24, 2017 at 03:38:20PM +0200, Simone Gotti wrote: > > > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an > > > active slot will block until it's released instead of returning an error > > > like > > > done in pg 9.6. Since this is a change in the previous behavior and the docs > > > wasn't changed I made a patch to restore the previous behavior. > > > > after git commit 9915de6c1cb calls to pg_drop_replication_slot or the > > > replication protocol DROP_REPLICATION_SLOT command will block when a > > > slot is in use instead of returning an error as before (as the doc > > > states). > > > > > > This patch will set nowait to true to restore the previous > > > behavior. > > > The above-described topic is currently a PostgreSQL 10 open item. > > Looking at it now -- next report tomorrow. This PostgreSQL 10 open item is past due for your status update. Kindly send a status update within 24 hours, and include a date for your subsequent status update. Refer to the policy on open item ownership: https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com
Commits
-
Restore behavior for replication origin drop
- f15b76a9010d 10.0 landed
- a6979c3a68e2 11.0 landed
-
Add a WAIT option to DROP_REPLICATION_SLOT
- 8ba6d50f923b 10.0 landed
- be7161566db2 11.0 landed
-
Fix race conditions in replication slot operations
- 9915de6c1cb2 10.0 cited