Horton

Re: [PATCH] Fix drop replication slot blocking instead of returning error

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Simone Gotti <simone.gotti@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-08-30T13:33:13Z
Lists: pgsql-hackers

Attachments

Craig Ringer wrote:

> > FWIW, I also don't think it's ok to just change the behaviour
> > unconditionally and without a replacement for existing behaviour.
> 
> Seems like it just needs a new argument nowait DEFAULT false

I added a WAIT flag to DROP_REPLICATION_SLOT, preliminary patch
attached.  Running tests now.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Restore behavior for replication origin drop

  2. Add a WAIT option to DROP_REPLICATION_SLOT

  3. Fix race conditions in replication slot operations