Re: Re: [PATCH] Fix drop replication slot blocking instead of returning error

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Noah Misch <noah@leadboat.com>
Cc: Simone Gotti <simone.gotti@gmail.com>, pgsql-hackers@postgresql.org
Date: 2017-08-29T10:04:33Z
Lists: pgsql-hackers
Noah Misch wrote:
> On Thu, Aug 24, 2017 at 03:38:20PM +0200, Simone Gotti wrote:
> > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an
> > active slot will block until it's released instead of returning an error
> > like
> > done in pg 9.6. Since this is a change in the previous behavior and the docs
> > wasn't changed I made a patch to restore the previous behavior.

> > after git commit 9915de6c1cb calls to pg_drop_replication_slot or the
> > replication protocol DROP_REPLICATION_SLOT command will block when a
> > slot is in use instead of returning an error as before (as the doc
> > states).
> > 
> > This patch will set nowait to true to restore the previous
> > behavior.

> The above-described topic is currently a PostgreSQL 10 open item.

Looking at it now -- next report tomorrow.


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Restore behavior for replication origin drop

  2. Add a WAIT option to DROP_REPLICATION_SLOT

  3. Fix race conditions in replication slot operations