Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-hackers@postgresql.org
Date: 2017-08-28T13:05:45Z
Lists: pgsql-hackers
Robert Haas wrote:
> pg_rewind: Fix some problems when copying files >2GB.
I just noticed that this broke pg_rewind translation, because of the
INT64_FORMAT marker in the translatable string. The message catalog now
has this:
msgid "received chunk for file \"%s\", offset "
for this source line:
pg_log(PG_DEBUG, "received chunk for file \"%s\", offset " INT64_FORMAT ", size %d\n",
filename, chunkoff, chunksize);
I don't think that this is terribly valuable as a translatable string,
so my preferred fix would be to have a new function pg_debug() here
where the messages are *not* marked for translations.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix translatable string
- 8d5ec8ee3809 9.5.10 landed
- a1af1e7cfaef 10.0 landed
- bd75335a83bf 9.6.6 landed
- 863d75439e87 11.0 landed
-
pg_rewind: Fix some problems when copying files >2GB.
- 73fbf3d3d0a5 9.6.4 cited