Re: Race-like failure in recovery/t/009_twophase.pl
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Date: 2017-07-02T15:00:30Z
Lists: pgsql-hackers
Tom Lane wrote: > Part of the reason I'm confused is that the programming technique > being used in 009_twophase.pl, namely doing > > ($node_master, $node_slave) = ($node_slave, $node_master); > > and then working with the reversed variable names, is ENTIRELY TOO CUTE > FOR ITS OWN GOOD. This is my fault. I noticed this in the submitted test (and was pretty confused about it too) when I reviewed it for commit, but somehow it didn't reach my threshold to require a rewrite. I'll fix it sometime during the week. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix race condition in recovery/t/009_twophase.pl test.
- 647675228f2b 10.0 landed
-
Fix bug in PostgresNode::query_hash's split() call.
- efdb4f29ba9e 10.0 landed
-
Try to improve readability of recovery/t/009_twophase.pl test.
- 4e15387d2d9d 10.0 landed