Re: Reducing pg_ctl's reaction time
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Janes <jeff.janes@gmail.com>, Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-06-26T21:50:18Z
Lists: pgsql-hackers
On 2017-06-26 17:38:03 -0400, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: > > On 2017-06-26 17:30:30 -0400, Tom Lane wrote: > >> No, I don't like that at all. Has race conditions against updates > >> coming from the startup process. > > > You'd obviously have to take the appropriate locks. I think the issue > > here is less race conditions, and more that architecturally we'd > > interact with shmem too much. > > Uh, we are *not* taking any locks in the postmaster. I'm not sure why you're 'Uh'ing, when my my point pretty much is that we do not want to do so? > Hm. Take that a bit further, and we could drop the connection probes > altogether --- just put the whole responsibility on the postmaster to > show in the pidfile whether it's ready for connections or not. Yea, that seems quite appealing, both from an architectural, simplicity, and log noise perspective. I wonder if there's some added reliability by the connection probe though? Essentially wondering if it'd be worthwhile to keep a single connection test at the end. I'm somewhat disinclined though. - Andres
Commits
-
Change pg_ctl to detect server-ready by watching status in postmaster.pid.
- f13ea95f9e47 10.0 landed
-
Reduce pg_ctl's reaction time when waiting for postmaster start/stop.
- c61559ec3a41 10.0 landed