Re: [patch] pg_dump/pg_restore zerror() and strerror() mishap

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Kunshchikov Vladimir <Vladimir.Kunshchikov@infotecs.ru>

Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2017-06-22T15:40:04Z

Lists: pgsql-hackers

Kunshchikov Vladimir wrote:

Hi,

>     our testing team has noticed apparently wrong backup/restore error messages like this:
> 
> 
> pg_restore: [compress_io] could not read from input file: success
> pg_dump: [directory archiver] could not write to output file: success
> 
> 
> 
> Such "success" messages are caused by calling strerror() after gzread()/gzwrite() failures.

Yeah, I've complained about this before but never got around to actually
fixing it.  Thanks for the patch, I'll see about putting it on all
branches soon.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Fix pg_dump's errno checking for zlib I/O
- 4d57e8381677 10.0 landed
- f3142c027212 9.5.8 landed
- 060393f2a136 9.6.4 landed
- 330e68734b82 9.4.13 landed
Add pg_basebackup tool for streaming base backups
- 048d148fe631 9.1.0 cited