Re: logical replication and PANIC during shutdown checkpoint in publisher
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Petr Jelinek <petr.jelinek@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-06-05T01:29:31Z
Lists: pgsql-hackers
Attachments
- 0001-Revert-Prevent-panic-during-shutdown-checkpoint.patch (text/x-patch)
On 2017-06-02 17:20:23 -0700, Andres Freund wrote: > Attached is a *preliminary* patch series implementing this. I've first > reverted the previous patch, as otherwise backpatchable versions of the > necessary patches would get too complicated, due to the signals used and > such. I went again through this, and the only real thing I found that there was a leftover prototype in walsender.h. I've in interim worked on backpatch versions of that series, annoying conflicts, but nothing really problematic. The only real difference is adding SetLatch() calls to HandleWalSndInitStopping() < 9.6, and guarding SetLatch with an if < 9.5. As an additional patch (based on one by Petr), even though it more belongs to http://archives.postgresql.org/message-id/20170421014030.fdzvvvbrz4nckrow%40alap3.anarazel.de attached is a patch unifying SIGHUP between normal and walsender backends. This needs to be backpatched all the way. I've also attached a second patch, again based on Petr's, that unifies SIGHUP handling across all the remaining backends, but that's something that probably more appropriate for v11, although I'm still tempted to commit it earlier. Michael, Peter, Fujii, is either of you planning to review this? I'm planning to commit this tomorrow morning PST, unless somebody protest till then. - Andres
Commits
-
Prevent possibility of panics during shutdown checkpoint.
- 862204aaceb1 9.6.4 landed
- 50581f2e74fa 9.5.8 landed
- 1cdc0ab9c180 9.4.13 landed
- c6c333436491 10.0 landed
-
Revert "Prevent panic during shutdown checkpoint"
- 703f148e98ec 10.0 landed
-
Prevent panic during shutdown checkpoint
- 086221cf6b17 10.0 cited