Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Christoph Berg <myon@debian.org>
From: Christoph Berg <myon@debian.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Jason Petersen <jason@citusdata.com>, pgsql-pkg-debian@postgresql.org, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-31T09:43:38Z
Lists: pgsql-hackers
Re: Tom Lane 2017-05-30 <1564.1496176732@sss.pgh.pa.us>
> It'd be interesting if people could gather similar numbers on other
> platforms of more real-world relevance, such as ppc64. But based on
> this small sample, I wouldn't object to just going to -fPIC across
> the board.
ppc64el, Debian unstable:
text data bss dec hex filename
-fpic: 79520 928 1768 82216 14128 postgres_fdw.so
-fPIC: 79520 928 1768 82216 14128 postgres_fdw.so
-> no change
s390x, Debian unstable:
text data bss dec hex filename
-fpic: 80735 2552 48 83335 14587 postgres_fdw.so
-fPIC: 81247 2552 48 83847 14787 postgres_fdw.so
-> +0.61%
arm64, Debian unstable:
text data bss dec hex filename
-fpic: 64130 2600 48 66778 104da postgres_fdw.so
-fPIC: 64274 2600 48 66922 1056a postgres_fdw.so
-> +0.22%
sparc64, Debian unstable:
text data bss dec hex filename
-fpic: 75804 3296 48 79148 1352c postgres_fdw.so
-fPIC: 72748 920 48 73716 11ff4 postgres_fdw.so
-> 6.9% decrease (!)
9.6.3, gcc (Debian 6.3.0-18) 6.3.0 20170516, -O2, all objects unstripped
(sparc64 is gcc (Debian 6.3.0-17) 6.3.0 20170510)
Christoph
Commits
-
Always use -fPIC, not -fpic, when building shared libraries with gcc.
- cee7238de58f 9.3.18 landed
- a378b9bc287d 9.2.22 landed
- 8d9b4fe01b5e 9.6.4 landed
- 894ce0e97ab1 9.4.13 landed
- 68938ab8ea0e 9.5.8 landed
- e9a3c047a5fc 10.0 landed