Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Christoph Berg <myon@debian.org>
From: Christoph Berg <myon@debian.org>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jason Petersen <jason@citusdata.com>, pgsql-pkg-debian@postgresql.org, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-30T16:52:58Z
Lists: pgsql-hackers
Re: Andres Freund 2017-05-30 <20170530161541.koj5xbvvovrrtxtd@alap3.anarazel.de> > I think we can fix this easily enough in Citus, postgis, and whatever. > But it's not a particularly good user/developer experience, and > presumably is going to become more and more common. On x86 there > shouldn't be a difference in efficiency between the two, but some others > will see some. Given that most distributions switched to building the > main executables with -fPIE anyway, to allow for ASLR, it seems unlikely > that the intra extension overhead is going to be very meaningful in > comparison. My main point here would be that we are already setting this for all extensions for sparc and sparc64, so s390(x) would just follow suit. -fPIC is the default in Debian now, see the discussion starting at https://lists.debian.org/debian-devel/2016/05/msg00028.html including the Fedora: https://lists.debian.org/debian-devel/2016/05/msg00219.html and Ubuntu: https://lists.debian.org/debian-devel/2016/05/msg00225.html situation, which all do that. Christoph
Commits
-
Always use -fPIC, not -fpic, when building shared libraries with gcc.
- cee7238de58f 9.3.18 landed
- a378b9bc287d 9.2.22 landed
- 8d9b4fe01b5e 9.6.4 landed
- 894ce0e97ab1 9.4.13 landed
- 68938ab8ea0e 9.5.8 landed
- e9a3c047a5fc 10.0 landed