Re: pgsql: Code review focused on new node types added by partitioning supp
Noah Misch <noah@leadboat.com>
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Date: 2017-05-30T02:32:17Z
Lists: pgsql-hackers
On Mon, May 29, 2017 at 03:20:41AM +0000, Tom Lane wrote: > Annotate the fact that somebody added location fields to PartitionBoundSpec > and PartitionRangeDatum but forgot to handle them in > outfuncs.c/readfuncs.c. This is fairly harmless for production purposes > (since readfuncs.c would just substitute -1 anyway) but it's still bogus. > It's not worth forcing a post-beta1 initdb just to fix this, but if we > have another reason to force initdb before 10.0, we should go back and > clean this up. +1 for immediately forcing initdb for this, getting it out of the way. We're already unlikely to reach 10.0 without bumping catversion, but if we otherwise did, releasing 10.0 with a 10beta1 catversion would have negative value.
Commits
-
Fix omission of locations in outfuncs/readfuncs partitioning node support.
- 80f583ffe930 10.0 landed
-
Code review focused on new node types added by partitioning support.
- 76a3df6e5e62 10.0 cited