translatable string fixes
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-21T18:52:38Z
Lists: pgsql-hackers
Attachments
- 0001-Make-messages-identical.patch (text/plain)
I noticed this entry while updating the translation for 9.6: #: catalog/index.c:3456 commands/vacuumlazy.c:1345 commands/vacuumlazy.c:1421 #: commands/vacuumlazy.c:1610 commands/vacuumlazy.c:1820 #, c-format msgid "%s." msgstr "%s." All of these correspond to errdetail printing pg_rusage_show() output. I think these are all bogus and should be changed to errdetail_internal() instead. Surely if we want pg_rusage_show() output to be translated, we should apply _() to the snprintf() call inside that function. At the same time, trying to append a period in the callers seems pointless; if we really feel a strong need for that period I suggest we add a flag to pg_rusage_show() to indicate whether to add it or not, though my inclination is not to bother. I also attach style fixes for other issues I found. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix wording in amvalidate error messages
- e6785a5ca16b 10.0 landed
- 1849b72169cd 9.6.4 landed