Re: bumping HASH_VERSION to 3

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-05-21T03:43:51Z
Lists: pgsql-hackers
On Sun, May 21, 2017 at 09:11:29AM +0530, Amit Kapila wrote:
> On Sun, May 21, 2017 at 5:26 AM, Bruce Momjian <bruce@momjian.us> wrote:
> > On Fri, May 19, 2017 at 04:54:27PM -0400, Robert Haas wrote:
> >> On Tue, May 16, 2017 at 9:25 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >> > On Tue, May 16, 2017 at 5:14 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> >> >> On Tue, May 16, 2017 at 7:31 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >> >>> I will send an updated patch once we agree on above points.
> >> >>
> >> >> Sounds good.
> >> >
> >> > Attached patch addresses all the comments as discussed.
> >>
> >> Committed.
> >
> > Just checking, but you reused some of my code from the 8.3-8.4 migration
> > in pg_upgrade that was removed a while back, rather than writing it from
> > scratch, right?
> >
> 
> Yes, I have adapted it to what is required for hash indexes, adjusted
> the code for v10 and there are some other minor changes in code.

Great, thanks.  It was hard to do originally so I am glad you could
reuse it.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


Commits

  1. pg_upgrade: Handle hash index upgrades more smoothly.

  2. Expand hash indexes more gradually.

  3. Cache hash index's metapage in rel->rd_amcache.