PostgreSQL 10beta1 - compilation fails on OpenBSD -current

Pierre-Emmanuel André <postgresql@raveland.org>

From: Pierre-Emmanuel André <postgresql@raveland.org>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-19T09:03:36Z
Lists: pgsql-hackers
Hi,

I tried to build PostgreSQL 10beta1 on OpenBSD -current and i have this error:

gmake[3]: Entering directory '/usr/ports/pobj/postgresql-10beta1/postgresql-10beta1/src/backend/libpq'
cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include    -c -o be-fsstubs.o be-fsstubs.c
cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include    -c -o be-secure.o be-secure.c
cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include    -c -o auth.o auth.c
auth.c: In function 'CheckBSDAuth':
auth.c:2265: error: too few arguments to function 'sendAuthRequest'


In auth.c, there is this call:
/* Send regular password request to client, and get the response */
sendAuthRequest(port, AUTH_REQ_PASSWORD);

but this function is defined like this:
static void sendAuthRequest(Port *port, AuthRequest areq, char *extradata,int extralen);


Regards,


Commits

  1. Fix compilation with --with-bsd-auth.

  2. Refactor sendAuthRequest.