Re: Bug in ExecModifyTable function and trigger issues for foreign tables
Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
From: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-15T09:16:38Z
Lists: pgsql-hackers
On Mon, 15 May 2017 10:34:58 +0530 Dilip Kumar <dilipbalaut@gmail.com> wrote: > On Sun, May 14, 2017 at 9:54 PM, Dilip Kumar <dilipbalaut@gmail.com> > wrote: > > After your fix, now tupleid is invalid which is expected, but seems > > like we need to do something more. As per the comments seems like it > > is expected to get the oldtuple from planSlot. But I don't see any > > code for handling that part. > > Maybe we should do something like attached patch. > Hi, planSlot contains already projected tuple, you can't use it as oldtuple. I think problem is that `rewriteTargetListUD` called only for parent relation, so there is no `wholerow` attribute for foreign tables. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company
Commits
-
Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE.
- 39f180fdd1e6 9.5.11 landed
- 06ba5309682e 9.6.7 landed
- a57aa430b613 10.2 landed
- 9a785ad57317 11.0 landed