Horton

Re: pgbench tap tests & minor fixes

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Robert Haas <robertmhaas@gmail.com>, Nikolay Shaplov <dhyan@nataraj.su>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-05-08T16:53:10Z
Lists: pgsql-hackers 
Fabien COELHO wrote:
> 
> Here is a v3, with less files. I cannot say I find it better, but it still
> works.
> 
> The "command_likes" function has been renamed "command_checks".

Do parts of this need to be backpatched?  I notice that you're patching
pgbench.c, probably to fix some bug(s); is the idea that we would
backpatch all the new tests on whatever old branches need the bugfixes
too?  If so, how far back do the fixes need to go?

ISTM TestLib::command_checks() needs a comment explaining what it does.
Its API seems pretty opaque.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add much-more-extensive TAP tests for pgbench.

  2. Be more careful about newline-chomping in pgbench.

  3. Fix some subtle problems in pgbench transaction stats counting.