Horton

Re: tuplesort_gettuple_common() and *should_free argument

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Peter Geoghegan <pg@heroku.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, hlinnaka <hlinnaka@iki.fi>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-07T00:04:42Z
Lists: pgsql-hackers 
On 2017-04-06 14:57:56 -0700, Peter Geoghegan wrote:
> On Thu, Apr 6, 2017 at 2:50 PM, Andres Freund <andres@anarazel.de> wrote:
> > Pushed with very minor wording changes.
> 
> This had a typo:
> 
> + * If copy is true, the slot receives a copied tuple that'll that will stay

Belatedly fixed.

Commits

  1. Fix duplicated words in comment.

  2. Remove should_free arguments to tuplesort routines.

  3. Fix use-after-free around DISTINCT transition function calls.