Horton

Thread

Commits

  1. Give nicer error message when connecting to a v10 server requiring SCRAM.

  1. Error message on missing SCRAM authentication with older clients

    Heikki Linnakangas <hlinnakangas@pivotal.io> — 2017-05-03T08:58:56Z

    Currently, if you use 9.6 libpq to connect to a v10 server that requires 
SCRAM authentication, you get an error:

psql: authentication method 10 not supported

I'd like to apply this small patch to all the stable branches, to give a 
nicer error message:

psql: SCRAM authentication not supported by this version of libpq

It won't help unless you upgrade to the latest minor version, of course, 
but it's better than nothing. Any objections?

- Heikki

  2. Re: Error message on missing SCRAM authentication with older clients

    Aleksander Alekseev <a.alekseev@postgrespro.ru> — 2017-05-03T12:12:28Z

    Hi Heikki,

> psql: SCRAM authentication not supported by this version of libpq

Maybe it would be better to specify a minimum required version?

-- 
Best regards,
Aleksander Alekseev

  3. Re: Error message on missing SCRAM authentication with older clients

    Magnus Hagander <magnus@hagander.net> — 2017-05-03T12:16:06Z

    On Wed, May 3, 2017 at 10:58 AM, Heikki Linnakangas <hlinnakangas@pivotal.io
> wrote:

> Currently, if you use 9.6 libpq to connect to a v10 server that requires
> SCRAM authentication, you get an error:
>
> psql: authentication method 10 not supported
>
> I'd like to apply this small patch to all the stable branches, to give a
> nicer error message:
>
> psql: SCRAM authentication not supported by this version of libpq
>
> It won't help unless you upgrade to the latest minor version, of course,
> but it's better than nothing. Any objections?


+1, even though it's not strictly speaking a bugfix to go in a backpatch, I
think it will help enough users that it's worth doing. And I can't see how
it could possibly be unsafe...

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

  4. Re: Error message on missing SCRAM authentication with older clients

    Aleksander Alekseev <a.alekseev@postgrespro.ru> — 2017-05-03T13:14:17Z

    Hi Magnus,

> +1, even though it's not strictly speaking a bugfix to go in a backpatch, I
> think it will help enough users that it's worth doing. And I can't see how
> it could possibly be unsafe...

Well, strictly speaking there could be applications that parse error
messages using regular expressions or something like this. But I don't
think it's something we should really bother about.

-- 
Best regards,
Aleksander Alekseev

  5. Re: Error message on missing SCRAM authentication with older clients

    Heikki Linnakangas <hlinnaka@iki.fi> — 2017-05-04T11:48:56Z

    On 05/03/2017 03:12 PM, Aleksander Alekseev wrote:
> Hi Heikki,
>
>> psql: SCRAM authentication not supported by this version of libpq
>
> Maybe it would be better to specify a minimum required version?

Yeah, that could be helpful. Can you suggest a wording?

My first thought was:

psql: SCRAM authentication not supported by this version of libpq 
(version 10 or above required)

But that's very long. Perhaps:

psql: SCRAM authentication requires libpq version 10 or above

- Heikki

  6. Re: Error message on missing SCRAM authentication with older clients

    Aleksander Alekseev <a.alekseev@postgrespro.ru> — 2017-05-05T08:19:40Z

    Hi Heikki,

> psql: SCRAM authentication requires libpq version 10 or above

Sounds good.

-- 
Best regards,
Aleksander Alekseev

  7. Re: Error message on missing SCRAM authentication with older clients

    Magnus Hagander <magnus@hagander.net> — 2017-05-05T08:26:07Z

    On Fri, May 5, 2017 at 10:19 AM, Aleksander Alekseev <
a.alekseev@postgrespro.ru> wrote:

> Hi Heikki,
>
> > psql: SCRAM authentication requires libpq version 10 or above
>
> Sounds good.
>
>
+1.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

  8. Re: Error message on missing SCRAM authentication with older clients

    Heikki Linnakangas <hlinnaka@iki.fi> — 2017-05-05T08:35:52Z

    On 05/05/2017 11:26 AM, Magnus Hagander wrote:
> On Fri, May 5, 2017 at 10:19 AM, Aleksander Alekseev <
> a.alekseev@postgrespro.ru> wrote:
>
>>> psql: SCRAM authentication requires libpq version 10 or above
>>
>> Sounds good.
>>
> +1.

Ok, committed. Thanks!

- Heikki