Horton

Thread

Commits

  1. Code review for commands/statscmds.c.

  1. Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

    David Rowley <david.rowley@2ndquadrant.com> — 2017-04-24T08:58:58Z

    The attached small patched fixes an incorrect usage of an error code
in the extended stats code.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

  2. Re: Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2017-04-24T13:26:39Z

    David Rowley wrote:
> The attached small patched fixes an incorrect usage of an error code
> in the extended stats code.

Thanks for the report.  I'm on vacation starting today until May 2nd.
If nobody commits this in the meantime, I'll get to it when I'm back.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  3. Re: Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-04-24T14:15:34Z

    David Rowley <david.rowley@2ndquadrant.com> writes:
> The attached small patched fixes an incorrect usage of an error code
> in the extended stats code.

Hmm, looks like all of that could do with an editorial pass (e.g.,
"duplicity" does not mean what the comments author seems to think).

			regards, tom lane

  4. Re: Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

    David Rowley <david.rowley@2ndquadrant.com> — 2017-04-25T07:11:55Z

    On 25 April 2017 at 02:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> David Rowley <david.rowley@2ndquadrant.com> writes:
>> The attached small patched fixes an incorrect usage of an error code
>> in the extended stats code.
>
> Hmm, looks like all of that could do with an editorial pass (e.g.,
> "duplicity" does not mean what the comments author seems to think).

Was about to look at this, but see you've beaten me to it.

Thanks for committing and for fixing the other stuff too.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services