Horton

Re: tuplesort_gettuple_common() and *should_free argument

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Peter Geoghegan <pg@heroku.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, hlinnaka <hlinnaka@iki.fi>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-04-06T21:50:35Z
Lists: pgsql-hackers 
On 2017-03-13 18:14:07 -0700, Peter Geoghegan wrote:
> On Wed, Jan 25, 2017 at 3:11 PM, Peter Geoghegan <pg@heroku.com> wrote:
> > On Wed, Jan 25, 2017 at 3:11 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> Please.  You might want to hit the existing ones with a separate patch,
> >> but it doesn't much matter; I'd be just as happy with a patch that did
> >> both things.
> >
> > Got it.
> 
> Attached is a patch that does both things at once.

Pushed with very minor wording changes.

Thanks,

Andres

Commits

  1. Fix duplicated words in comment.

  2. Remove should_free arguments to tuplesort routines.

  3. Fix use-after-free around DISTINCT transition function calls.