Re: Statement timeout behavior in extended queries
Tatsuo Ishii <ishii@sraoss.co.jp>
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: andres@anarazel.de
Cc: ishii@sraoss.co.jp, tsunakawa.takay@jp.fujitsu.com, david@fetter.org,
pgsql-hackers@postgresql.org
Date: 2017-04-05T01:22:08Z
Lists: pgsql-hackers
>> What's your point of the question? What kind of problem do you expect >> if the timeout starts only once at the first parse meesage out of >> bunch of parse messages? > > It's perfectly valid to send a lot of Parse messages without > interspersed Sync or Bind/Execute message. There'll be one timeout > covering all of those Parse messages, which can thus lead to a timeout, > even though nothing actually takes long individually. Hmm. IMO, that could happen even with the current statement timeout implementation as well. Or we could start/stop the timeout in exec_execute_message() only. This could avoid the problem above. Also this is more consistent with log_duration/log_min_duration_statement behavior than now. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Commits
-
Rearm statement_timeout after each executed query.
- f8e5f156b30e 11.0 landed