Horton

Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Cynthia Shang <cynthia.shang@crunchydata.com>

View thread View on postgr.es
From: Cynthia Shang <cynthia.shang@crunchydata.com>
To: pgsql-hackers@postgresql.org
Cc: Vladimir Rusinov <vrusinov@google.com>
Date: 2016-12-29T16:43:34Z
Lists: pgsql-hackers 
1) I agree with Michael that we should make this change backward compatible. It would help PostgreSQL image if we did not break everyone's code. It costs businesses money to rewrite code (e.g. middle tier software, backup tools, etc), test and redeploy to their customers. 

2) We decided to rename the pg_xlog directory because people were deleting it when disks were getting full thinking it was just unimportant logging data; I get that. I'm a little unclear why we need to change the functions - it would be less painful to our users and less risky if we just left them as is. Could someone please elaborate why this change is necessary? I'm just trying to understand that.

Thanks,
-Cynthia

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid