Horton

Re: Declarative partitioning vs. sql_inheritance

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>, Michael Paquier <michael.paquier@gmail.com>, Andres Freund <andres@anarazel.de>, Erik Rijkers <er@xs4all.nl>, Amit Langote <amitlangote09@gmail.com>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>, pgsql-hackers-owner@postgresql.org
Date: 2016-12-19T16:48:48Z
Lists: pgsql-hackers 
Robert Haas wrote:
> On Fri, Dec 16, 2016 at 7:39 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> >> On 12/16/16 11:05 AM, Robert Haas wrote:
> >>> If we were going to do anything about this,
> >>> my vote would be to remove sql_inheritance.
> >
> >> Go for it.
> >
> >> Let's also remove the table* syntax then.
> >
> > Meh --- that might break existing queries, to what purpose?
> >
> > We certainly shouldn't remove query syntax without a deprecation period.
> > I'm less concerned about that for GUCs.
> 
> I agree.  Patch attached, just removing the GUC and a fairly minimal
> amount of the supporting infrastructure.

Any particular reason not to change inhOpt to be a simple boolean, and
remove the enum?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Replace enum InhOption with simple boolean.

  2. Remove sql_inheritance GUC.