Re: Renaming of pg_xlog and pg_clog
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Christoph Berg <myon@debian.org>, Stephen Frost <sfrost@snowman.net>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael.paquier@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@enterprisedb.com>, Craig Ringer <craig.ringer@2ndquadrant.com>, Jim Nasby <Jim.Nasby@bluetreble.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2016-10-18T22:09:10Z
Lists: pgsql-hackers
On Fri, Oct 14, 2016 at 07:19:02PM +0200, Christoph Berg wrote: > Re: Stephen Frost 2016-10-14 <20161014113523.GZ13284@tamriel.snowman.net> > > > We have a tool called pg_xlogdump in the standard installation. initdb > > > has an option --xlogdir, pg_basebackup has --xlog and others. Renaming > > > the xlog directory would make this all a bit confusing, unless we're > > > prepared to rename the programs and options as well. > > > > pg_xlogdump is not a user-facing tool, frankly, so I don't believe we > > should be terribly concerned about either leaving it named as-is or > > renaming it. I agree that we should consider adding alternative names > > to the options for initdb and pg_basebackup. > > There's actually another instance of "rename so people shoot their > feet less often" here: pg_resetxlog, which is a user-facing tool. > Folks on #postgresql have repeatedly been joking that it should rather > be named pg_eatmydata, given the number of "howtos" on the web that > make use of it. Maybe this is the chance to find a less > innocent-sounding name. (Or add a mandatory --rewind-my-data switch.) I wonder how many of the uses of pg_resetxlog were caused by mistakenly removing the pg_xlog directory. My point is renaming pg_xlog might reduce mistake use of pg_resetxlog. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Commits
-
Rename "pg_clog" directory to "pg_xact".
- 88e66d193fba 10.0 landed
-
Improve error reporting in pg_upgrade's file copying/linking/rewriting.
- f002ed2b8e45 10.0 cited