Re: pgsql: Improve internationalization of messages involving type names

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Date: 2016-03-30T21:43:54Z
Lists: pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Also, change them all to use the same quoting convention, namely that
> > the function name is not to be quoted but the type name is.  (I'm not
> > quite sure why this is so, but it's the clear majority.)
> 
> Actually, I think the general convention is to NOT quote type names
> in error messages.  Certainly that's so when using format_type_be()
> to produce a name for a not-known-at-compile-time type.  I would
> argue that these messages should be written to look the same as if
> format_type_be() had been used, and that would mean leaving off
> the quotes.

Ok, I'll change it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Make messages mentioning type names more uniform

  2. Improve internationalization of messages involving type names

  3. psql tab-complete for CREATE/DROP ACCESS METHOD