Horton

Re: Increasing timeout of poll_query_until for TAP tests

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2016-08-03T17:34:05Z
Lists: pgsql-hackers 
Michael Paquier wrote:
> On Wed, Aug 3, 2016 at 7:21 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> > Why not capture both items in a single select, such as in the attached
> > patch?
> 
> Let me test this....
> [... A while after ...]
> This looks to work properly. 12 runs in a row have passed.

Okay, applied that way.

BTW, one-line long queries look awful in that perl code.  I don't
propose to change anything now, but I propose that long queries are
split using here-docs in new code,

$node->safe_psql(<<EQ);
SELECT foo
  FROM bar
EQ

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. In tests, await an LSN no later than the recovery target.