Re: remove checkpoint_warning

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Geoghegan <pg@heroku.com>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2016-07-11T21:54:28Z
Lists: pgsql-hackers
* Andres Freund (andres@anarazel.de) wrote:
> On 2016-07-11 11:14:29 -0700, Peter Geoghegan wrote:
> > On Mon, Jul 11, 2016 at 7:25 AM, Stephen Frost <sfrost@snowman.net> wrote:
> > >> Or in short, this may be a fine change to make, but I don't like your
> > >> argument for it.
> > >
> > > I don't agree that it's sensible to get rid of.  Having just
> > > log_checkpoints will have the logs filled with checkpoints starting
> > > because of XLOG, but there's no indication of that being a bad thing.
> > 
> > I agree. checkpoint_warning exists for the benefit of novice DBAs.
> > I've seen those warnings in customer logs on several occasions, at
> > least back when I was a consultant.
> 
> Note that the situation changed a bit with 9.5, because our defaults
> aren't absurdly conservative (checkpoint_segments = 3) anymore.

Agreed, but I don't think that means we'll never see that warning
again..

Thanks!

Stephen