Re: increase message string buffer size of watch command of psql
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Ioseph Kim <pgsql-kr@postgresql.kr>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-06-15T20:38:03Z
Lists: pgsql-hackers
Tom Lane wrote:
> I wrote:
> > Well, we did part of that, but it's still using asctime(). Should we
> > change that to strftime(..."%c"...) to be less English-centric?
> > (The result seems to be the same in C locale. pg_controldata has done
> > it that way for a long time, with few complaints.) If we want to do so,
> > now would be the time, since 9.6 already whacked around the format
> > of \watch output.
>
> I take it from the vast silence that nobody particularly cares one way
> or the other. On reflection I think that this would be a good change
> to make, so I'll go do so unless I hear complaints soon.
+1 to strftime("%c"). If we wanted to provide additional flexibility we
could have a \pset option to change the strftime format string to
something other than %c, but I don't think there's enough demand to
justify it.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Improve header output from psql's \watch command.
- dea2b5960a94 9.6.0 cited