Horton

Re: Getting Citus into (Debian) PGDG

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Christoph Berg <myon@debian.org>, Jason Petersen <jason@citusdata.com>, pgsql-pkg-debian@postgresql.org
Date: 2016-04-27T23:05:16Z
Lists: pgsql-hackers 
On 2016-04-26 17:32:35 +0200, Christoph Berg wrote:
> Re: To Jason Petersen 2016-04-26 <20160426151339.GF12563@msg.df7cb.de>
> > I've had that problem before, but forgot most of it. I think the
> > problem is that "-fPIC -pie  -fpic" isn't consistent and should
> > probably be "-fPIC -PIE", but I might be totally wrong. (I'll try to
> > dig up some docs.)
> 
> Just talked to a s390x porter, the flags used should be -fPIC -pie",
> i.e. without the lower case version.

Afaics, that's citus independent, and coming from postgres code.
Makefile.port:
ifeq "$(findstring sparc,$(host_cpu))" "sparc"
CFLAGS_SL = -fPIC
else
CFLAGS_SL = -fpic
endif

I'm not clear why citus triggers this, when other extensions don't?

Andres

Commits

  1. Always use -fPIC, not -fpic, when building shared libraries with gcc.