Re: Patch to show individual statement latencies in pgbench output
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Smith <greg@2ndquadrant.com>
Cc: Florian Pflug <fgp@phlo.org>, PostgreSQL-development hackers <pgsql-hackers@postgresql.org>
Date: 2010-08-12T17:48:53Z
Lists: pgsql-hackers
Greg Smith <greg@2ndquadrant.com> writes: > Florian Pflug wrote: >> Attached is an updated version (v4). > I've attached a v5. No real code changes from Florian's version, just > some wording/style fixes and rework on the documentation. I'm looking through this patch now. It looks mostly good, but I am wondering just exactly what is the rationale for adding comment statements to the data structures, rather than ignoring them as before. It seems like a complete waste of logic, memory space, and cycles; moreover it renders the documentation's statement that comments "are ignored" incorrect. I did not find anything in the patch history explaining the point of that change. regards, tom lane