Horton

Re: BUG #13741: vacuumdb does not accept valid password

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>, Haribabu Kommi <kommi.haribabu@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, brown@fastmail.com, "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>, pgsql-hackers@postgresql.org
Date: 2015-12-23T16:55:44Z
Lists: pgsql-bugs, pgsql-hackers 
Tom Lane wrote:

> Sorry for having lost track of this.  I think if we're going to do this,
> we should do it now not later, because it essentially reverts the
> connectDatabase() API change made in 83dec5a71 in favor of a different API
> change with the same purpose.  Now, that doesn't matter if no third-party
> code is using connectDatabase(), but I have a suspicion that there
> probably is some.  Any such users will not thank us for whacking
> connectDatabase's API around in 9.5 and then whacking it around
> differently in 9.6.
> 
> In short, I think we should apply this now and back-patch into 9.5,
> like the prior patch, even though we're post-RC1.  The reduction in
> cross-version API churn is worth it.
> 
> If no objections, I'll go do that shortly.

No objection here.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. vacuumdb: don't prompt for passwords over and over