Re: BUG #13741: vacuumdb does not accept valid password

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>, brown@fastmail.com, "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>
Date: 2015-11-02T19:26:26Z
Lists: pgsql-bugs, pgsql-hackers
Michael Paquier wrote:
> On Mon, Nov 2, 2015 at 8:10 PM, Haribabu Kommi wrote:
> > Here I attached modified patch that gets the password from parent connection
> > if exists and use it for the child connection also.
> 
> Meh? Why the parent connection? You could simply have the password as
> an argument of connectDatabase, per se the attached. That looks just
> more simple.

Thanks!  This is almost there, but there's an important missing piece --
vacuumdb --all will ask you for a password for each database.  I think
vacuum_one_database needs to receive a password from its caller too.

(Also, please use pg_strdup.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. vacuumdb: don't prompt for passwords over and over