Re: pgbench stats per script & other stuff
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Josh Berkus <josh@agliodbs.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2015-09-02T21:55:41Z
Lists: pgsql-hackers
On 2015-09-02 14:36:51 -0400, Robert Haas wrote: > On Wed, Sep 2, 2015 at 2:20 PM, Fabien COELHO <coelho@cri.ensmp.fr> wrote: > >> I'm wondering if percentages instead of weights would be a better > >> idea. That'd mean you'd be forced to be more careful when adding another > >> script (having to adjust the percentages of other scripts) but arguably > >> that's a good thing? > > > > If you use only percent, then you have to check that the total is 100, > > probably you have to use floats, to do something when the total is not 100, > > checking would complicate the code and test people mental calculus > > abilities. Not sure this is a good idea:-) > > I agree. I don't see a reason to enforce that the total of the > weights must be 100. I'm slightly worried that using weights will be a bit confusing because adding another script will obviously reduce the frequency of already defined scripts. But it's probably not worth worrying. Andres
Commits
-
pgbench: Allow changing weights for scripts
- 7bafffea647e 9.6.0 landed