Re: nodes/*funcs.c inconsistencies

Noah Misch <noah@leadboat.com>

From: Noah Misch <noah@leadboat.com>
To: Joe Conway <mail@joeconway.com>
Cc: Stephen Frost <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2015-08-06T01:16:01Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add support for renaming domain constraints

On Mon, Aug 03, 2015 at 09:57:52AM -0700, Joe Conway wrote:
> On 08/03/2015 09:55 AM, Stephen Frost wrote:
> > * Noah Misch (noah@leadboat.com) wrote:
> >> On Sun, Aug 02, 2015 at 11:31:16PM -0400, Tom Lane wrote:
> >>> That being the case, it would probably be a good idea to get
> >>> them done before alpha2, as there may not be a good opportunity
> >>> afterwards.
> >> 
> >> Freedom to bump catversion after alpha2 will be
> >> barely-distinguishable from freedom to do so now.  I have planned
> >> to leave my usual comment period of a few days, though skipping
> >> that would be rather innocuous in this case.
> > 
> > This is clearly necessary, of course, and I wouldn't be surprised
> > if we have another necessary bump post-alpha2, but at the same
> > time, it'd certainly be nice if we are able to put out alpha2 and
> > then a beta1 in the future without needing to do a bump.
> > 
> > In other words, +1 from me for going ahead and committing this for 
> > alpha2, if possible.
> 
> +1

Rather than commit on an emergency basis in the few hours between these +1's
and the wrap, I kept to my original schedule.  FYI, if it hadn't required
emergency procedures (cancelling the day's plans so I could get to a notebook
computer), I would have committed early based on the three +1s.