Re: nodes/*funcs.c inconsistencies

Noah Misch <noah@leadboat.com>

From: Noah Misch <noah@leadboat.com>

To: pgsql-hackers@postgresql.org

Cc: robertmhaas@gmail.com, sfrost@snowman.net

Date: 2015-08-02T20:28:43Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add support for renaming domain constraints
- 38b9693fd984 9.2.0 cited

Attachments

nodefuncs-95features-v1.patch (text/plain) patch v1

On Mon, Apr 16, 2012 at 06:25:15AM -0400, Noah Misch wrote:
> I observed these inconsistencies in node support functions:

A fresh audit found the attached problems new in 9.5[1].  Most are cosmetic
INT/UINT or field order corrections.  The non-cosmetic changes involve
CustomPath, CustomScan, and CreatePolicyStmt.  Feature committers, if the
existing treatments (ignore custom_plans/custom_paths fields; copy/compare
"cmd" string pointer as a scalar) were deliberate, please let me know.

Thanks,
nm

[1] The _equalCreateEventTrigStmt() cosmetic change is relevant as far back as
9.3, but I won't back-patch it further than the others (9.5).