Re: Lack of Sanity Checking in file 'pctcl.c' for PostgreSQL 9.4.x

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bill Parker <wp02855@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Date: 2015-07-19T15:44:49Z
Lists: pgsql-bugs
Michael Paquier wrote:
> On Sun, Jul 19, 2015 at 5:19 AM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:

> > With some additional effort, we could get rid of perm_fmgr_info, at
> > least in pltcl.  (That hack was introduced in a3ed622b63b and
> > 7748e9e7e5a back in 2001 and we never actually fixed it ...)
> 
> Yes it seems so, even for plperl and plpython there seem to be some
> room for improvement at quick glance... This looks like a master-only
> change to me though (and I am sure we are on the same page). For
> back-branches something like the previous patch is definitely safer.

Yes, agreed on both counts.  I will push the patch when I have a moment.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Fix (some of) pltcl memory usage