Horton

Re: a fast bloat measurement tool (was Re: Measuring relation free space)

Abhijit Menon-Sen <ams@2ndquadrant.com>

View thread
From: Abhijit Menon-Sen <ams@2ndQuadrant.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Simon Riggs <simon@2ndquadrant.com>
Date: 2015-04-24T02:34:10Z
Lists: pgsql-hackers 
At 2015-04-24 07:22:27 +0530, amit.kapila16@gmail.com wrote:
>
> Few minor issues:
> 1.
> warning on windows
> 
> \pgstatbloat.c(193): warning C4715: 'pgstatbloat' : not all control paths
> return a value

This is because the function ends with an ereport(ERROR, …). What would
you suggest here? Just stick a PG_RETURN_NULL() at the end?

> 2.
> Failed to install pgstattuple--1.3.sql
> 
> You have to name sql file as pgstattuple--1.3.sql rather
> than pgstattuple--1.2.sql

How are you applying the patch? It already contains this:

    diff --git a/contrib/pgstattuple/pgstattuple--1.2.sql b/contrib/pgstattuple/pgstattuple--1.3.sql
    similarity index 73%
    rename from contrib/pgstattuple/pgstattuple--1.2.sql
    rename to contrib/pgstattuple/pgstattuple--1.3.sql
    index e5fa2f5..93593ee 100644
    --- a/contrib/pgstattuple/pgstattuple--1.2.sql
    +++ b/contrib/pgstattuple/pgstattuple--1.3.sql

So it should do the right thing with git apply.

-- Abhijit