Re: a fast bloat measurement tool (was Re: Measuring relation free space)

Abhijit Menon-Sen <ams@2ndquadrant.com>

From: Abhijit Menon-Sen <ams@2ndQuadrant.com>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Simon Riggs <simon@2ndQuadrant.com>

Date: 2015-04-22T13:03:33Z

Lists: pgsql-hackers

Attachments

0001-20150422-Add-pgstatbloat-to-pgstattuple.patch (text/x-diff) patch 0001
inter.diff (text/x-diff) patch

At 2015-04-18 12:28:36 +0530, amit.kapila16@gmail.com wrote:
>
> I think you have missed to address the below point:
> 
> >> 4) prefetch

Updated patch attached, as well as the diff against the earlier version
just to make it easier to see the exact change I made (which is to copy
the skip logic from lazy_scan_heap, as you suggested).

I'm not entirely convinced that this change is worthwhile, but it's easy
to make and difficult to argue against, so here it is. (I did test, and
it seems to work OK after the change.)

Amit, Tomas, thanks again for your review comments.

-- Abhijit