Re: narwhal and PGDLLIMPORT

Noah Misch <noah@leadboat.com>

From: Noah Misch <noah@leadboat.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Magnus Hagander <magnus@hagander.net>, Dave Page <dpage@pgadmin.org>, Alvaro Herrera <alvherre@2ndquadrant.com>, Hiroshi Inoue <inoue@tpf.co.jp>, Andrew Dunstan <andrew@dunslane.net>, Craig Ringer <craig@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2014-10-20T15:24:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

MinGW: Link with shell32.dll instead of shfolder.dll.
- 53566fc0940c 9.5.0 cited
Centralize getopt-related declarations in a new header file pg_getopt.h.
- 60ff2fdd9970 9.4.0 cited
Get rid of use of dlltool in Mingw builds.
- 846e91e0223c 9.4.0 cited
Export a few more symbols required for test_shm_mq module.
- 7d7eee8bb702 9.4.0 cited
Export set_latch_on_sigusr1 symbol for Windows.
- 708c529c7fde 9.4.0 cited
Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the
- 889f03812916 8.1.0 cited

On Mon, Oct 20, 2014 at 11:06:54AM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > I don't expect to understand the mechanism
> > behind it, but I recommend we switch back to linking libpq with shell32.dll.
> > The MSVC build already does that in all supported branches, and it feels right
> > for the MinGW build to follow suit in 9.4+.  Windows versions that lack the
> > symbol in shell32.dll are now ancient history.
> 
> This is basically reverting 889f038, right?

Mostly so.  Keeping the SHGetSpecialFolderPath() -> SHGetFolderPath() part,
but reverting the shell32.dll -> shfolder.dll part.