Re: Escaping from blocked send() reprised.

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: andres@2ndquadrant.com
Cc: hlinnakangas@vmware.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Date: 2014-10-10T06:48:56Z
Lists: pgsql-hackers
Hmm.. Sorry for my stupidity.

> Why is that necessary? It seems really rather wrong to make
> BIO_set_retry_write() dependant on ProcDiePending? Especially as, at
> least in my testing, it's not even required because the be_tls_write()
> can just check the error properly?

I mistook the previous conversation as it doesn't work as
expected. I confirmed that it works fine.

After all, it works as I expected. The parameter for
ProcessClientWriteInterrupt() looks somewhat uneasy but the patch
4 looks fine as a whole. Do you have anything to worry about in
the patch?

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



Commits

  1. Assert that WaitLatchOrSocket callers cannot wait only for writability.