Horton
Menu

Re: Custom Scan APIs (Re: Custom Plan node)

Stephen Frost <sfrost@snowman.net>

View thread
From: Stephen Frost <sfrost@snowman.net>
To: Shigeru Hanada <shigeru.hanada@gmail.com>
Cc: Kouhei Kaigai <kaigai@ak.jp.nec.com>, Kohei KaiGai <kaigai@kaigai.gr.jp>, Jim Mlodgenski <jimmy76@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PgHacker <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>
Date: 2014-02-26T08:03:40Z
Lists: pgsql-hackers 
* Shigeru Hanada (shigeru.hanada@gmail.com) wrote:
> Perhaps he meant to separate patches based on feature-based rule.  IMO
> if exposing utilities is essential for Custom Scan API in practical
> meaning, IOW to implement and maintain an extension which implements
> Custom Scan API, they should be go into the first patch.  IIUC two
> contrib modules are also PoC for the API, so part-2/3 patch should
> contain only changes against contrib and its document.

That's what I was getting at, yes.

> Besides that, some typo fixing are mixed in part-2 patch.  They should
> go into the part-1 patch where the typo introduced.

Agreed.

	THanks,

		Stephen

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Support multi-argument UNNEST(), and TABLE() syntax for multiple functions.