Re: narwhal and PGDLLIMPORT

Andres Freund <andres@2ndquadrant.com>

From: Andres Freund <andres@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Marco Atzeri <marco.atzeri@gmail.com>, pgsql-hackers@postgresql.org

Date: 2014-02-15T19:49:54Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

MinGW: Link with shell32.dll instead of shfolder.dll.
- 53566fc0940c 9.5.0 cited
Centralize getopt-related declarations in a new header file pg_getopt.h.
- 60ff2fdd9970 9.4.0 cited
Get rid of use of dlltool in Mingw builds.
- 846e91e0223c 9.4.0 cited
Export a few more symbols required for test_shm_mq module.
- 7d7eee8bb702 9.4.0 cited
Export set_latch_on_sigusr1 symbol for Windows.
- 708c529c7fde 9.4.0 cited
Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the
- 889f03812916 8.1.0 cited

On 2014-02-15 14:35:02 -0500, Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> > Patch attached.
> 
> Committed with some cosmetic adjustments --- thanks!
> 
> > I am not sure whether HAVE_GETOPT is the best condition
> > to use, since it's set by configure by a link based check, same goes for
> > HAVE_INT_OPTERR. The other choices would be relying on HAVE_GETOPT_H or
> > a new AC_CHECK_DECL.
> 
> I'm pretty sure HAVE_GETOPT is *not* what we want to use for the variable
> declarations.  I've tried HAVE_GETOPT_H for the moment, but that may need
> more tweaking depending on what the buildfarm has to say.

I only used it because it was what previously protected the getopt()
declaration in port.h... But that should probably have been depending on
!HAVE_GETOPT_H in the first place.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services