Horton

Re: BRIN indexes - TRAP: BadArgument

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Erik Rijkers <er@xs4all.nl>, Heikki Linnakangas <hlinnakangas@vmware.com>, Emanuel Calvo <3manuek@esdebian.org>, Simon Riggs <simon@2ndquadrant.com>, Nicolas Barbier <nicolas.barbier@gmail.com>, Claudio Freire <klaussfreire@gmail.com>, Josh Berkus <josh@agliodbs.com>, Andres Freund <andres@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2014-09-24T03:03:16Z
Lists: pgsql-hackers 
Robert Haas wrote:
> On Tue, Sep 23, 2014 at 9:23 PM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:

> > If you or somebody else want to give it a look, I have
> > no problem waiting a bit longer.  I don't want to delay indefinitely,
> > though, because I think it's better shipped early in the release cycle
> > than later, to allow for further refinements and easier testing by other
> > interested parties.
> 
> I agree with that.  I'd like to look at it, and I will if I get time,
> but as I said elsewhere, I also think it's appropriate to give a
> little time around the final version of any big, complex patch just
> because people may have thoughts, and they may not have time to
> deliver those thoughts the minute the patch hits the list.

Fair enough -- I'll keep it open for the time being.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Refactor per-page logic common to all redo routines to a new function.

  2. Reduce use of heavyweight locking inside hash AM.

  3. Scan the buffer pool just once, not once per fork, during relation drop.

  4. Major patch from Thomas Lockhart <Thomas.G.Lockhart@jpl.nasa.gov>