Horton

Re: Review: ECPG FETCH readahead

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Boszormenyi Zoltan <zboszor@pr.hu>
Cc: Antonin Houska <antonin.houska@gmail.com>, PG Hackers <pgsql-hackers@postgresql.org>, Michael Meskes <meskes@postgresql.org>, Noah Misch <noah@leadboat.com>, Peter Eisentraut <peter_e@gmx.net>, Robert Haas <robertmhaas@gmail.com>, Heikki Linnakangas <hlinnakangas@vmware.com>, Bruce Momjian <bruce@momjian.us>, Hans-Jürgen Schönig <hs@cybertec.at>
Date: 2014-04-24T14:26:02Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix some "translator:" comments mangled by pgindent

  2. Make sure float4in/float8in accept all standard spellings of "infinity".

Just a quickie: I remember noticing earlier that a few comments on
functions would probably get mangled badly by pgindent.  You probably
want to wrap them in /*-----   */ to avoid this.  In a very quick glance
now I saw them in ecpg_get_data, ecpg_cursor_next_pos, ECPGfetch.
Perhaps you want to run pgindent on the files you modify, review the
changes, and apply tweaks to avoid unwanted ones.  (I don't mean to
submit pgindented files, because they will be fixed later on anyway; I
only suggest tweaking things that would be damaged.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services