Horton

Re: Review: ECPG FETCH readahead

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Antonin Houska <antonin.houska@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Boszormenyi Zoltan <zboszor@pr.hu>, PG Hackers <pgsql-hackers@postgresql.org>, Michael Meskes <meskes@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>, Robert Haas <robertmhaas@gmail.com>, Heikki Linnakangas <hlinnakangas@vmware.com>, Bruce Momjian <bruce@momjian.us>, Hans-Jürgen Schönig <hs@cybertec.at>
Date: 2014-04-24T01:54:36Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix some "translator:" comments mangled by pgindent

  2. Make sure float4in/float8in accept all standard spellings of "infinity".

On Thu, Apr 24, 2014 at 12:15:41AM +0200, Antonin Houska wrote:
> Whether this review is enough to move the patch to "ready for committer"
> - I tend to let the next CFM decide. (I don't find it productive to
> ignite another round of discussion about kinds of reviews - already saw
> some.)

In today's CF process, we trust reviewers to make that decision.  When all
unambiguous defects known to you have been resolved, please mark the patch
Ready for Committer.  Your review covered more ground than the average review,
so don't worry about it being too cursory to qualify.

Thanks,
nm

-- 
Noah Misch
EnterpriseDB                                 http://www.enterprisedb.com