Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Dean Rasheed <dean.a.rasheed@gmail.com>

Cc: Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>

Date: 2013-12-02T20:28:01Z

Lists: pgsql-bugs, pgsql-hackers

Dean Rasheed escribió:

> I think that memory gets freed at the end of the DROP command, so I
> don't think this is a concern. In any case, that RangeVar is only of
> order 50 bytes. If we were concerned about memory leakage here, a
> bigger concern would be the calling code in does_not_exist_skipping(),
> which is using NameListToString() which allocates at least 1024 bytes
> for the name of the non-existent object without freeing it.

Fair enough.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services